Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify the AEAD_CHACHA20_POLY1305 Key size in section 6.1 Encryption #19

Closed
defuse opened this issue Mar 3, 2016 · 1 comment
Closed

Specify the AEAD_CHACHA20_POLY1305 Key size in section 6.1 Encryption #19

defuse opened this issue Mar 3, 2016 · 1 comment
Labels
protocol spec

Comments

@defuse
Copy link
Contributor

defuse commented Mar 3, 2016

We should mention that the key is 256-bits. I had to look up the RFC to make sure it was, since if it was only 128 bits keys could collide. I suppose this is implied by the output sizes of KDF and PRFdk but I'm not that clever!
daira added a commit that referenced this issue Mar 7, 2016
@daira
Clarify that the nonce to AEAD_CHACHA20_POLY1305 is 96 bits, and the …
e15a4fc 
…key 256 bits.

fixes zips/#19

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
@daira
Copy link
Collaborator

daira commented Mar 7, 2016

Fixed in e15a4fc

@daira daira closed this as completed Mar 7, 2016
daira pushed a commit to daira/zips that referenced this issue Nov 8, 2023
@vivek-arte @PaulLaux
Handling additional suggestions from PR#649 and PR#628 (zcash#19)
3a914c5 
Making updates based on pending reviews from
[PR#649](zcash#649) and
[PR#628](zcash#628).
daira pushed a commit to daira/zips that referenced this issue Feb 7, 2024
@vivek-arte @daira
Handling additional suggestions from PR#649 and PR#628 (zcash#19)
9c82f32 
Making updates based on pending reviews from
[PR#649](zcash#649) and
[PR#628](zcash#628).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
protocol spec
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daira @defuse