Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors v2 codec handling #2425

Merged
merged 4 commits into from
Oct 24, 2024
Merged

Refactors v2 codec handling #2425

merged 4 commits into from
Oct 24, 2024

Conversation

normanrz
Copy link
Member

@normanrz normanrz commented Oct 21, 2024

This PR refactors the handling of codecs for v2 arrays by introducing a new private V2Codec class instead of V2Filters and V2Compressor. It just applies the filters/codecs in order without caring about buffer types.

closes #2325

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@normanrz normanrz self-assigned this Oct 21, 2024
@normanrz normanrz added the V2 Affects the v2 branch label Oct 21, 2024
@jhamman jhamman added V3 and removed V2 Affects the v2 branch labels Oct 21, 2024
@mpiannucci
Copy link

Chiming in to say that I tested this with existing kerchunk stores and it works great!

@jhamman jhamman merged commit 109f71f into main Oct 24, 2024
33 checks passed
@jhamman jhamman deleted the v2-codec branch October 24, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v3] V2 Codec pipeline is not consistent with legacy usage of filters
3 participants