Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made all tag generators produce fixed set of tags #901

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Made all tag generators produce fixed set of tags #901

merged 1 commit into from
Feb 18, 2020

Conversation

whiskeysierra
Copy link
Contributor

Description

Motivation and Context

See micrometer-metrics/micrometer#877 (comment)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@whiskeysierra whiskeysierra force-pushed the bugfix/prometheus-stable-tags branch from 62d1139 to 7a7495b Compare February 18, 2020 20:25
@whiskeysierra whiskeysierra changed the title Bugfix/prometheus stable tags Made all tag generators produce fixed set of tags Feb 18, 2020
@whiskeysierra whiskeysierra force-pushed the bugfix/prometheus-stable-tags branch from 7a7495b to d23829c Compare February 18, 2020 20:39
@whiskeysierra
Made all tag generators produce fixed set of tags
c45e914 
Works around an issue with prometheus which enforces that
@whiskeysierra whiskeysierra force-pushed the bugfix/prometheus-stable-tags branch from d23829c to c45e914 Compare February 18, 2020 21:06
@lukasniemeier-zalando
Copy link
Member

👍

@whiskeysierra whiskeysierra merged commit 5c8a077 into master Feb 18, 2020
@whiskeysierra whiskeysierra deleted the bugfix/prometheus-stable-tags branch February 18, 2020 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderYastrebov AlexanderYastrebov Awaiting requested review from AlexanderYastrebov

@lukasniemeier-zalando lukasniemeier-zalando Awaiting requested review from lukasniemeier-zalando

@patandrick patandrick Awaiting requested review from patandrick

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whiskeysierra @lukasniemeier-zalando