Skip to content

Commit

Permalink
bgzf/writer/builder: Rename Builder::build_with_writer to Builder::bu…
Browse files Browse the repository at this point in the history
…ild_from_writer
  • Loading branch information
zaeleus committed Aug 27, 2024
1 parent e601e3d commit 1ecb318
Show file tree
Hide file tree
Showing 5 changed files with 38 additions and 7 deletions.
13 changes: 13 additions & 0 deletions noodles-bgzf/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,18 @@
# Changelog

## Unreleased

### Changed

* bgzf/writer/builder: Rename `Builder::build_with_writer` to
`Builder::build_from_writer`.

### Deprecated

* bgzf/writer/builder: Deprecate `Builder::build_with_writer`.

Use `Builder::build_from_writer` instead.

## 0.32.0 - 2024-07-14

### Added
Expand Down
2 changes: 1 addition & 1 deletion noodles-bgzf/src/async/writer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ where
/// let writer = bgzf::AsyncWriter::new(Vec::new());
/// ```
pub fn new(inner: W) -> Self {
Builder::default().build_with_writer(inner)
Builder::default().build_from_writer(inner)
}

/// Returns the underlying writer.
Expand Down
15 changes: 12 additions & 3 deletions noodles-bgzf/src/async/writer/builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -53,17 +53,17 @@ impl Builder {
self
}

/// Builds an async BGZF writer.
/// Builds an async BGZF writer from a writer.
///
/// # Examples
///
/// ```
/// # use tokio::io;
/// use noodles_bgzf as bgzf;
/// let writer = bgzf::r#async::writer::Builder::default()
/// .build_with_writer(io::sink());
/// .build_from_writer(io::sink());
/// ```
pub fn build_with_writer<W>(self, writer: W) -> Writer<W>
pub fn build_from_writer<W>(self, writer: W) -> Writer<W>
where
W: AsyncWrite,
{
Expand All @@ -80,4 +80,13 @@ impl Builder {
compression_level: compression_level.into(),
}
}

/// Builds an async BGZF writer.
#[deprecated(since = "0.33.0", note = "Use `Builder::build_from_writer` instead.")]
pub fn build_with_writer<W>(self, writer: W) -> Writer<W>
where
W: AsyncWrite,
{
self.build_from_writer(writer)
}
}
2 changes: 1 addition & 1 deletion noodles-bgzf/src/writer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ where
/// let writer = bgzf::Writer::new(io::sink());
/// ```
pub fn new(inner: W) -> Self {
Builder::default().build_with_writer(inner)
Builder::default().build_from_writer(inner)
}

/// Returns a reference to the underlying writer.
Expand Down
13 changes: 11 additions & 2 deletions noodles-bgzf/src/writer/builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ impl Builder {
/// ```
/// # use std::io;
/// use noodles_bgzf as bgzf;
/// let writer = bgzf::writer::Builder::default().build_with_writer(io::sink());
/// let writer = bgzf::writer::Builder::default().build_from_writer(io::sink());
/// ```
pub fn build_with_writer<W>(self, writer: W) -> Writer<W>
pub fn build_from_writer<W>(self, writer: W) -> Writer<W>
where
W: Write,
{
Expand All @@ -47,4 +47,13 @@ impl Builder {
compression_level: self.compression_level.into(),
}
}

/// Builds a BGZF writer from a writer.
#[deprecated(since = "0.33.0", note = "Use `Builder::build_from_writer` instead.")]
pub fn build_with_writer<W>(self, writer: W) -> Writer<W>
where
W: Write,
{
self.build_from_writer(writer)
}
}

0 comments on commit 1ecb318

Please sign in to comment.