Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

potentially unsafe multicall #13

Closed
stevennevins opened this issue Mar 18, 2022 · 1 comment
Closed

potentially unsafe multicall #13

stevennevins opened this issue Mar 18, 2022 · 1 comment

Comments

@stevennevins
Copy link

linking this discussion on use of msg.value in payable functions and multicall
@z0r0z
Copy link
Owner

z0r0z commented Mar 18, 2022

thanks @stevennevins This seems like a good fix. The only benefit of having multi-call payable is gas-optimization by avoiding redundant check in solidity. Will remove payable keyword as it's not worth it, and this contract will hold LP ETH.

@z0r0z z0r0z closed this as completed in 9ab32a1 Mar 19, 2022
leon-superdev added a commit to leon-superdev/Solidity-token-exchange-exercise that referenced this issue Mar 30, 2024
@leon-superdev
Update Multicall.sol
0dde5de 
resolve z0r0z/helios#13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stevennevins @z0r0z