Added HTML support for Button labels #1162
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
Y.Button
widgets do not support HTML labels. This is an issue because is isn't uncommon to use nested HTML structures inside of a<button>
element. For example...To fix this issue, this pull request introduces a
labelHTML
ATTR, and relegates thelabel
ATTR as secure sugar aroundlabelHTML
.A separate attribute is required for the following reasons:
label
ATTRAdditional notes
@config
instead of@attribute
in ButtonCore documentation because@attribute
will include theChange
events to the API documentation, which ButtonCore (derived from AttributeCore) does not fire.Test Results