Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark menu bar is missing #1

Closed
zelid opened this issue Jun 19, 2019 · 3 comments
Closed

Dark menu bar is missing #1

zelid opened this issue Jun 19, 2019 · 3 comments

Comments

@zelid
Copy link

zelid commented Jun 19, 2019

I've downloaded master version on 19-July-2019 and everything looks good (submenus, popups, titlbar, scrollbars) all beside menu.

menu

Windows Explorer has dark menu.
How to use the same dark menu styling as Windows Explorer has?
@ysc3839
Copy link
Owner

ysc3839 commented Jun 20, 2019

Windows Explorer does not have dark menu, that is Ribbon UI with dark theme.
It seems that Windows does not provide dark menu bar, so I can't solve this issue.

@ysc3839 ysc3839 closed this as completed Jun 20, 2019
@tom-huntington
Copy link

Was going to ask you to do a dark themed UI but then I realized choosing the color was built in to the ribbon framework.

Just for my curiosity, how did you learn the undocumented API?

@ysc3839
Copy link
Owner

ysc3839 commented Feb 23, 2020

@tom-huntington Using IDA and x64dbg to decompile system executables.

@jonaskohl jonaskohl mentioned this issue Aug 5, 2020
Open
madsmtm added a commit to madsmtm/winit that referenced this issue Jan 26, 2021
@madsmtm
Add WindowBuilderExtWindows.with_menu, that
cfc72ad 
Unresolved:
- Child windows cannot have a menu
- Dark mode doesn't look good with win32 menus (might not be fixable, see ysc3839/win32-darkmode#1 )
madsmtm added a commit to madsmtm/winit that referenced this issue Jan 26, 2021
@madsmtm
Add ability to assign a menu when creating a window on Windows
17d463d 
The primary reason for doing this here instead of just assigning a menu later on with `SetMenu` is to avoid that `with_inner_size` breaks, since the menu takes up some space that is not taken into account, which means the user would have to use `set_inner_size` again after adding the menu.

Notes:
- Child windows cannot have a menu, so perhaps this should be represented typewise?
- Dark mode doesn't look good with win32 menus, unfortunately not fixable, see ysc3839/win32-darkmode#1
madsmtm added a commit to madsmtm/winit that referenced this issue Jan 26, 2021
@madsmtm
Add ability to assign a menu when creating a window on Windows
02583b2 
The primary reason for doing this here instead of just assigning a menu later on with `SetMenu` is to avoid that `with_inner_size` breaks, since the menu takes up some space that is not taken into account, which means the user would have to use `set_inner_size` again after adding the menu.

Notes:
- Child windows cannot have a menu, so perhaps this should be represented typewise?
- Dark mode doesn't look good with win32 menus, unfortunately not fixable, see ysc3839/win32-darkmode#1
martijnlaan referenced this issue in jrsoftware/issrc Apr 24, 2024
@martijnlaan
Add dark mode support to the context menus on Windows 10 Version 1903…
f6249ed 
… and later. \o/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zelid @ysc3839 @tom-huntington