Skip to content

docs(Overlay): fix the misleading overlay example #13399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 23, 2025
Merged

docs(Overlay): fix the misleading overlay example #13399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4ae307
fix(Docs): fix the misleading overlay example
pany-ang Mar 18, 2025
d68d311
chore: 完善英文文档 && 重新激活 `CI / test (pull_request)`
pany-ang Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/vant/src/overlay/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,12 @@ export default {

### Embedded Content

Any content can be embedded on the overlay through the default slot.

```html
<van-overlay :show="show" @click="show = false">
<div class="wrapper" @click.stop>
<div class="block" />
<div class="wrapper">
<div class="block" @click.stop />
</div>
</van-overlay>

Expand Down
4 changes: 2 additions & 2 deletions packages/vant/src/overlay/README.zh-CN.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ export default {

```html
<van-overlay :show="show" @click="show = false">
<div class="wrapper" @click.stop>
<div class="block" />
<div class="wrapper">
<div class="block" @click.stop />
</div>
</van-overlay>

Expand Down
2 changes: 1 addition & 1 deletion packages/vant/src/overlay/demo/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ const showZIndex = ref(false);
/>
<van-overlay :show="showEmbedded" @click="showEmbedded = false">
<div class="wrapper">
<div class="block" />
<div class="block" @click.stop />
</div>
</van-overlay>
</demo-block>
Expand Down