-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example timers #99
Conversation
Thanks for the PR! |
In my opinion, we can remove the |
1s doesn't make sense but 30s would make sense for example. I think most people would interpret "01:00" as one minute and not as one hour |
Agreed, it makes more sense to remove the |
I'd prefer to keep them also as this makes all timers the same width and thus easier for eyes to read as one can immediately jump to the minutes and hours parts |
In my opinion that's just wasted space, your screenshot could contain 4 timers instead of the current 3 when removing the 00: at the beginning. |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR adds example quick selection timers to the CreateTimerScreen
This allows users to quickly select from common timers, such as 10 minutes, 15 minutes, half an hour, an hour etc.
out.mp4