-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use relative layout in widgets #181
Conversation
Okay i found an issue. On my pixel 7 it works fine, but not on the emulator. I think the hardcoded fontsize is the issue. |
Yes, we should make the font size dynamic depending on the screen size probably, that'll probably work best by using a |
I can do that with the dimen-values. If we define values that way, do we need two layouts per widget? I would also introduce color to the text, is it okay if i do it in this PR? |
I think it'd work to remove the duplicated widgets and just handle everything through dimens.
Depends on how it looks, if everyone agrees on it, we'll merge it, otherwise we'll undo the color changes and merge it without. Just do as you like and we'll wee then. |
This is how the clocks look like now. However, if the user has set the font-size to a large setting, it will break out again. We could fix that by using dp, but i am not sure if that is a good idea. However, this PR should improve the code either way by a bit |
On my device, the widgets look kind of fat and out of place now:
So I think your changes are a good beginning, but we should continue improving responsiveness before merging. PS: I really like the color changes though! |
@newhinton are you still working on this? |
The issue is that i dont really now how a dynamic font could work. I tried looking at aosp's stock clock, but that is not really useful since it only has a fixed size that only increases borders like this pr currently. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, (and sorry for the delay)!
This will should fix #127.
It will also make the widget "resizable", so that the internal background color will now stretch to fill the actual size of the widget.