Lots more feature and performance changes. Discuss! #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-safe logging) Moved core and station to new common log functions (_info and _err) using new QueueLogger Core now attempts to restart stations that stop Core now detects new folders on the fly instead of only at start time (stationfolder option) Station.py has a lot of changes to utilize the common blocking queue only when needed rather than at every step (may increase performance with many stations) TODO: Detect proper vs unexpected shutdown of stations and restart only unexpected ones Make new folder detection for stationfolder an option
|
There's some issues with this (primarily that newly found stations don't start). I'm prepping a new pull request to replace this. |
|
OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new QueueLogger class (logging from a queue so we can do thread-safe logging)
Moved core and station to new common log functions (_info and _err) using new QueueLogger
Core now attempts to restart stations that stop
Core now detects new folders on the fly instead of only at start time (stationfolder option)
Station.py has a lot of changes to utilize the common blocking queue ( self.q.get(1) ) only when needed rather than at every step (may increase performance on installs with many stations)
Lots more error handling when blocking queue is utilized to ensure that one error doesn't kill other threads
Renamed station and stations variables within core to be more clear what they contain
TODO:
Detect proper vs unexpected shutdown of stations and restart only unexpected ones
Make new folder detection for stationfolder an option