fix(llm_tools): fix permission checking to use relative path #1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yetone
reviewed
Mar 3, 2025
The has_permission_to_access function was incorrectly using absolute paths when checking against gitignore patterns. This could cause issues when the binary name matches the project root directory name, particularly in Go projects. Changes: - Extract relative path from absolute path by removing project root prefix - Use relative path for gitignore pattern matching - Add comments explaining the path handling logic Signed-off-by: Hanchin Hsieh <me@yuchanns.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In projects such as Go, the output binary artifacts are automatically named after the project; for instance, the binary of a project called "go-project" is also referred to as "go-project." Users generally add the project name to .gitignore to prevent these artifacts from being submitted.
Currently, the method used to check .gitignore relies on absolute paths and fuzzy matching, which can result in files being incorrectly identified as ignored:
IMO the checker should only take care of the path inside the project root