Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for ollama RAG providers #1427

Merged
merged 12 commits into from
Mar 4, 2025
Merged

feat: add support for ollama RAG providers #1427

merged 12 commits into from
Mar 4, 2025

Conversation

nzlov
Copy link
Contributor

@nzlov nzlov commented Feb 28, 2025

  • Added provider, model and endpoint configuration options for RAG service
  • Updated RAG service to support Ollama providers
  • Added Ollama embedding support and dependencies
  • Improved environment variable handling for RAG service configuration

#1407

- Added provider, model and endpoint configuration options for RAG service

- Updated RAG service to support both OpenAI and Ollama providers

- Added Ollama embedding support and dependencies

- Improved environment variable handling for RAG service configuration

Signed-off-by: wfhtqp@gmail.com <wfhtqp@gmail.com>
@nzlov nzlov changed the title feat: add support for multiple RAG providers feat: add support for ollama RAG providers Feb 28, 2025
@nzlov nzlov changed the title feat: add support for ollama RAG providers [WIP]feat: add support for ollama RAG providers Feb 28, 2025
@nzlov
Copy link
Contributor Author

nzlov commented Feb 28, 2025

LLM is still needed for parsing, so this should also be configurable.

@nzlov nzlov changed the title [WIP]feat: add support for ollama RAG providers feat: add support for ollama RAG providers Feb 28, 2025
@yetone
Copy link
Owner

yetone commented Mar 1, 2025

‌‌‌‌LGTM, you might need to fix the py lint error:

pre-commit run --color=always --files $(find ./py -type f -name "*.py")

@yetone
Copy link
Owner

yetone commented Mar 1, 2025

‌‌‌‌Thank you for the contribution! We should synchronize the documents and inform everyone on how to customize the RAG provider. Adding a few examples would be even better.

Additionally, will switching providers abruptly render the previous provider's embedding invalid? We should address this issue.

@nzlov
Copy link
Contributor Author

nzlov commented Mar 2, 2025

Tell users in the documentation that they need to delete previous data when changing providers?

@yetone
Copy link
Owner

yetone commented Mar 2, 2025

Tell users in the documentation that they need to delete previous data when changing providers?

Can we do this automatically?

@nzlov
Copy link
Contributor Author

nzlov commented Mar 2, 2025

Due to pre-commit update version, need to wait for the third-party package to update and fix the error

@yetone
Copy link
Owner

yetone commented Mar 3, 2025

‌‌‌‌Can you use pyright: ignore to temporarily ignore the error on this line?

@nzlov
Copy link
Contributor Author

nzlov commented Mar 4, 2025

OK, thanks for your help

@yetone yetone merged commit de7cccd into yetone:main Mar 4, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants