Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: python tool message formatting and check for docker #1379

Merged
merged 3 commits into from
Feb 25, 2025

Conversation

PeterCardenas
Copy link
Contributor

I encountered a couple of different issues with the python tool:

  1. There was a typo in the confirm message and it is a bit unclear.
  2. When docker is not installed, the tool fails and the response does not finish.

I have fixed the first issue by fixing the typo, listing out the container name, and making sure that the code starts on a new line.
The second issue was fixed by first checking if docker is installed, and if not, sending back a message to the LLM to make it clear that the Python tool should not be used. I had a bit of prompt engineering here since a simple error message here made the LLM try the python tool again with simpler python scripts.

@PeterCardenas PeterCardenas mentioned this pull request Feb 25, 2025
@PeterCardenas
Copy link
Contributor Author

additionally, the confirm message seems quite jank after putting the newline, maybe we should consider some different UI instead of vim.fn.confirm

@yetone
Copy link
Owner

yetone commented Feb 25, 2025

additionally, the confirm message seems quite jank after putting the newline, maybe we should consider some different UI instead of vim.fn.confirm

I am using a float window to replace vim.fn.confirm in another branch.

@yetone yetone merged commit aa0449d into yetone:main Feb 25, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants