This repository has been archived by the owner on Mar 26, 2018. It is now read-only.
feat(gen): add welcome message and dep notice for minsafe #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.installDependencies({ skipInstall: this.options['skip-install'] }); | ||
| this.installDependencies({ | ||
| skipInstall: this.options['skip-install'], | ||
| skipMessage: options['skip-install-message'] |
There was a problem hiding this comment.
Was this meant to be skip-welcome-message?
Either way, I wouldn't be concerned with logging out two helpful messages being annoying to people. And if they are annoyed, I would file it under "Oh, well." That's just my opinion, though. :)
There was a problem hiding this comment.
I grabbed that line from webapp. It could probably be left off and it is probably a typo.
Adds a Yeoman welcome message. Add a deprecation notice for the minsafe option. Closes #452
|
LGTM. Thanks Eddie! |
addyosmani
added a commit
that referenced
this pull request
Dec 8, 2013
feat(gen): add welcome message and dep notice for minsafe
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a Yeoman welcome message. Add a deprecation notice for the minsafe
option.
Closes #452