Register Generators (as stubs) with resolved path #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SBoudrias
reviewed
Jun 23, 2018
lib/environment.js
Outdated
| @@ -244,9 +244,10 @@ class Environment extends EventEmitter { | |||
| * | |||
| * @param {Function} Generator - A Generator constructor or a simple function | |||
| * @param {String} namespace - Namespace under which register the generator | |||
| * @param {String} resolved - The file path to the generator | |||
There was a problem hiding this comment.
Let's mark this parameter as optional (let's apply everywhere)
* @param {String} [resolved] ...
lib/store.js
Outdated
| @@ -43,9 +44,9 @@ class Store { | |||
| }); | |||
| } | |||
|
|
|||
| _storeAsModule(namespace, Generator) { | |||
| _storeAsModule(namespace, Generator, resolved) { | |||
There was a problem hiding this comment.
Let's use a default argument here: resolved = 'unknown'
|
Looks good to me, just 2 small changes to make. |
|
Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a
resolvedparameter toregisterStubto allow the generator to be stored with aresolvedpath other than'unknown'.With this change it is possible to adapt
yeoman-test/RunContextto run a Generator as a module together with the path associated to it. This is crucial for working with transpiled generators, as the code source is in a different path from the actually executed code path and there has to be a way to separate the generator itself from it's associated file system path to have a decent experience (eg: having coverage results from the source code, not the transpiled code). I'll make the PR toyemoan-testafter this is merged.