Set up CI with Azure Pipelines

azure-pipelines.yml

@@ -0,0 +1,107 @@
+# Node.js
+# Build a general Node.js project with npm.
+# Add steps that analyze code, save build artifacts, deploy, and more:
+# https://docs.microsoft.com/azure/devops/pipelines/languages/javascript
+
+jobs:
+
+- job: Windows
+
+  pool: 'Hosted VS2017'
+
+  strategy:
+    matrix:
+#       node_8_x:
+#         node_version: 8.x
+      node_10_x:
+        node_version: 10.x
+
+  steps:
+  - task: NodeTool@0
+    inputs:
+      versionSpec: $(node_version)
+    displayName: 'Install Node.js'
+
+  - bash: |
+      yarn
+      yarn run build
+      ls -lhR bin
+      ls -lhR lib
+    displayName: 'install and build'
+
+  - script: |
+      cd packages/pkg-tests
+      yarn
+    displayName: 'install the acceptance tests'
+
+  - script: |
+      cd packages/pkg-tests
+      yarn jest yarn --detectOpenHandles
+    displayName: 'run the acceptance tests'
+
+# - job: Linux
+#
+#   pool:
+#     vmImage: 'Ubuntu 16.04'
+#
+#   strategy:
+#     matrix:
+#       node_8_x:
+#         node_version: 8.x
+#       node_10_x:
+#         node_version: 10.x
+#
+#   steps:
+#   - task: NodeTool@0
+#     inputs:
+#       versionSpec: $(node_version)
+#     displayName: 'Install Node.js'
+#
+#   - script: |
+#       yarn
+#       yarn build
+#     displayName: 'install and build'
+#
+#   - script: |
+#       cd packages/pkg-tests
+#       yarn
+#     displayName: 'install the acceptance tests'
+#
+#   - script: |
+#       cd packages/pkg-tests
+#       yarn jest yarn
+#     displayName: 'run the acceptance tests'
+#
+# - job: OSX
+#
+#   pool:
+#     vmImage: 'macOS 10.13'
+#
+#   strategy:
+#     matrix:
+#       node_8_x:
+#         node_version: 8.x
+#       node_10_x:
+#         node_version: 10.x
+#
+#   steps:
+#   - task: NodeTool@0
+#     inputs:
+#       versionSpec: $(node_version)
+#     displayName: 'Install Node.js'
+#
+#   - script: |
+#       yarn
+#       yarn build
+#     displayName: 'install and build'
+#
+#   - script: |
+#       cd packages/pkg-tests
+#       yarn
+#     displayName: 'install the acceptance tests'
+#
+#   - script: |
+#       cd packages/pkg-tests
+#       yarn jest yarn
+#     displayName: 'run the acceptance tests'
+#

packages/pkg-tests/package.json

@@ -25,7 +25,7 @@
     },
     "jest": {
         "modulePathIgnorePatterns": [
-            "<rootDir>[/\\\\]pkg-tests-fixtures[/\\\\]packages[/\\\\]"
+            "<rootDir>/pkg-tests-fixtures/packages/"
         ]
     }
 }

packages/pkg-tests/pkg-tests-core/sources/utils/exec.js

@@ -12,6 +12,8 @@ exports.execFile = function(
       if (error) {
         reject(error);
       } else {
+        stdout = stdout.replace(/\r\n?/g, `\n`);
+        stderr = stderr.replace(/\r\n?/g, `\n`);
         resolve({stdout, stderr});
       }
     });

packages/pkg-tests/pkg-tests-core/sources/utils/fs.js

@@ -75,13 +75,13 @@ exports.packToStream = function packToStream(
   const packStream = tarFs.pack(source, {
     map: header => {
       if (true) {
-        header.name = path.resolve('/', header.name);
-        header.name = path.relative('/', header.name);
+        header.name = path.posix.resolve('/', header.name);
+        header.name = path.posix.relative('/', header.name);
       }
 
       if (virtualPath) {
-        header.name = path.resolve('/', virtualPath, header.name);
-        header.name = path.relative('/', header.name);
+        header.name = path.posix.resolve('/', virtualPath, header.name);
+        header.name = path.posix.relative('/', header.name);
       }
 
       return header;

packages/pkg-tests/pkg-tests-core/sources/utils/tests.js

@@ -364,3 +364,9 @@ exports.generatePkgDriver = function generatePkgDriver({runDriver}: {|runDriver:
 
   return withConfig({});
 };
+
+exports.testIf = function testIf(condition, ...args) {
+  if (condition()) {
+    test(...args);
+  }
+};

packages/pkg-tests/pkg-tests-specs/sources/pnp.js

@@ -4,7 +4,7 @@ const {relative, isAbsolute} = require('path');
 
 const {
   fs: {createTemporaryFolder, readFile, readJson, writeFile, writeJson},
-  tests: {getPackageDirectoryPath},
+  tests: {getPackageDirectoryPath, testIf},
 } = require('pkg-tests-core');
 
 module.exports = makeTemporaryEnv => {
@@ -619,7 +619,8 @@ module.exports = makeTemporaryEnv => {
       ),
     );
 
-    test(
+    testIf(
+      () => process.platform !== 'win32',
       `it should generate a file that can be used as an executable to resolve a request (valid request)`,
       makeTemporaryEnv(
         {
@@ -648,7 +649,8 @@ module.exports = makeTemporaryEnv => {
       ),
     );
 
-    test(
+    testIf(
+      () => process.platform !== `win32`,
       `it should generate a file that can be used as an executable to resolve a request (builtin request)`,
       makeTemporaryEnv(
         {
@@ -672,7 +674,8 @@ module.exports = makeTemporaryEnv => {
       ),
     );
 
-    test(
+    testIf(
+      () => process.platform !== `win32`,
       `it should generate a file that can be used as an executable to resolve a request (invalid request)`,
       makeTemporaryEnv(
         {

packages/pkg-tests/yarn.test.js

@@ -1,6 +1,6 @@
 /* @flow */
 
-const {delimiter} = require(`path`);
+const {delimiter, join} = require(`path`);
 
 const {
   tests: {generatePkgDriver, startPackageServer, getPackageRegistry},
@@ -64,6 +64,11 @@ const pkgDriver = generatePkgDriver({
   },
 });
 
+if (process.platform === `win32`) {
+  // Windows takes much longer to run those tests, for some reason
+  jest.setTimeout(15000);
+}
+
 beforeEach(async () => {
   await startPackageServer();
   await getPackageRegistry();

src/fetchers/tarball-fetcher.js

@@ -148,7 +148,7 @@ export default class TarballFetcher extends BaseFetcher {
       reject(new MessageError(this.config.reporter.lang('errorExtractingTarball', err.message, tarballPath)));
     });
 
-    extractorStream.pipe(untarStream).on('finish', () => {
+    const end = () => {
       const error = this.validateError;
       const hexDigest = this.validateIntegrity ? this.validateIntegrity.hexDigest() : '';
       if (
@@ -189,7 +189,12 @@ export default class TarballFetcher extends BaseFetcher {
       return resolve({
         hash: this.hash || hexDigest,
       });
+    };
+
+    extractorStream.pipe(untarStream).on('finish', () => {
+      setTimeout(end, 1000);
     });
+
     return {validateStream, extractorStream};
   }
 

src/util/generate-pnp-map-api.tpl.js

@@ -33,7 +33,7 @@ const isDirRegExp = /\/$/;
 const isStrictRegExp = /^\.{0,2}\//;
 
 // Splits a require request into its components, or return null if the request is a file path
-const pathRegExp = /^(?!\.{0,2}(?:\/|$))((?:@[^\/]+\/)?[^\/]+)\/?(.*|)$/;
+const pathRegExp = /^(?![a-zA-Z]:[\\\/]|\\\\|\.{0,2}(?:\/|$))((?:@[^\/]+\/)?[^\/]+)\/?(.*|)$/;
 
 // Keep a reference around ("module" is a common name in this context, so better rename it to something more significant)
 const pnpModule = module;
@@ -323,7 +323,7 @@ exports.resolveToUnqualified = function resolveToUnqualified(request, issuer, {c
   // contain multiple levels of dependencies (ie. a yarn.lock inside a subfolder of a yarn.lock). This is
   // typically solved using workspaces, but not all of them have been converted already.
 
-  if (ignorePattern && ignorePattern.test(issuer)) {
+  if (ignorePattern && ignorePattern.test(normalizePath(path.normalize(issuer)))) {
     const result = callNativeResolution(request, issuer);
 
     if (result === false) {