Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated empty locales file after yargs got an error. #48

Closed
gucong3000 opened this issue Jul 26, 2017 · 2 comments · Fixed by chauncey-garrett/dotfiles#11
Closed

Generated empty locales file after yargs got an error. #48

gucong3000 opened this issue Jul 26, 2017 · 2 comments · Fixed by chauncey-garrett/dotfiles#11

Comments

@gucong3000
Copy link

gucong3000 commented Jul 26, 2017

We use yargs and y18n:
https://github.com/jedmao/eclint/blob/master/lib/cli.ts#L202

When yargs throw a error by demandCommand(1, 1, i18n('CommandError: Missing required sub-command.'))

yargs will kill main process. and y18n not finsh file write.

After executed this steps, any commands dump parse errors.

/usr/local/lib/node_modules/eclint/node_modules/y18n/index.js:79
    else throw err
         ^

SyntaxError: syntax error in /usr/local/lib/node_modules/eclint/locales/ja_JP.json
    at JSON.parse (<anonymous>)
@gucong3000
Copy link
Author

Any plan? This issue attaches importance to reproduction, interfering with CI operation

@bcoe
Copy link
Member

bcoe commented Aug 10, 2017

@gucong3000 hey 👋 sorry for the slow reply; I see you might have found the solution and have a patch open on y18n? I will work on getting this landed for you ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants