[8.0] Fixes from PHPStan #1569
Merged
[8.0] Fixes from PHPStan #1569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thanks for introducing phpstan, this is the first time I heard about it and looks like a great utility. Will try this also on my other packages. :) |
|
If you want, I can add |
|
That sounds interesting, can you please do submit a PR for travis for me to see how it works? :) |
|
I'll just wait for Weebly/phpstan-laravel#1 to fix some Laravel magic calls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After run
PHPStanup to level 5, some code could get improved in Laravel Datatables 😄