(Issue #50) JAVA_HOME should be set by YARN, not by client #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this really fixes it. If JAVA_HOME is set on the launcher box it will still be used to run the app master. The only difference is that the JAVA_HOME environment variable will not be set for the app master when it was set previously (Which may be enough). I would prefer to see a config that can be used to override JAVA_HOME on the remote cluster. If it is set we use it, if it is not set we assume java will be on the path and go with that. This would also give us the ability to pick between different JDKs that are installed on the same box. Think 32-bit vs 64-bit JDK, instead of relying on the JDK that the NodeManager is running with. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.