-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continuous integration tests for sampling #525
Open
thjsal
wants to merge
18
commits into
520-feature-using-latinhypercube-for-priordraw
Choose a base branch
from
CI-tests-for-sampling
base: 520-feature-using-latinhypercube-for-priordraw
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Continuous integration tests for sampling #525
thjsal
wants to merge
18
commits into
520-feature-using-latinhypercube-for-priordraw
from
CI-tests-for-sampling
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a couple of new GitHub CI tests checking that
unit_hypercube_frac
returns the same value as before.Sampling with UltraNest does not crash. To make this test work I needed to add a requirement that GitHub installs UltraNest version that is newer than 4.0. Otherwise, test failed if using python3.9 or python3.10 (where it installed older UltraNest by default, which seemed inconsistent with the installed Numpy version).
I tried also adding a test for MultiNest, but could not in the end get the test program to find the MultiNest library files. However, I left the MultiNest installation and the corresponding test there as commented out if someone will figure out how to get it working.