VS-1557: Allow unstructuring of attrs classes in typing.Any-typed fields #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xaviergmail
commented
Nov 10, 2022
Comment on lines
+1
to
+19
| from typecats import Cat, try_struc | ||
|
|
||
|
|
||
| def test_with_no_default(): | ||
| @Cat | ||
| class Thing(dict): | ||
| name: str | ||
|
|
||
| assert try_struc(Thing, None) is None | ||
| assert Thing.try_struc(None) is None | ||
|
|
||
|
|
||
| def test_with_default(): | ||
| @Cat | ||
| class Thing(dict): | ||
| name: str = "" | ||
|
|
||
| assert try_struc(Thing, None) is None | ||
| assert Thing.try_struc(None) is None |
There was a problem hiding this comment.
I had this file leftover in my working tree from something in the past. It's not related to this PR but wouldn't hurt.
danielxoi
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression in cattrs >= 1.2.0: python-attrs/cattrs#320. It is again a very naïve solution but fixes the regression here.