Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK Naming and Function Cleanup #477

Merged
merged 22 commits into from
Mar 11, 2025
Merged

SDK Naming and Function Cleanup #477

merged 22 commits into from
Mar 11, 2025

Conversation

nplasterer
Copy link
Contributor

@nplasterer nplasterer commented Mar 8, 2025

  • Remove App Version
  • ConvoId should be renamed to conversationId
  • fallbackContent to fallback
  • imageUrlSquare to imageUrl
  • group should be removed from names inside group class
  • Rename Message to DecodedMessage
  • Rename ConversationType to ConversationFilterType
  • Add new return type for addMembers

@nplasterer nplasterer self-assigned this Mar 8, 2025
@nplasterer nplasterer requested review from a team as code owners March 8, 2025 00:36
Base automatically changed from np/passkey-read to main March 10, 2025 22:37
Copy link
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@nplasterer nplasterer merged commit 2a10b1e into main Mar 11, 2025
1 of 2 checks passed
@nplasterer nplasterer deleted the np/breaking-changes branch March 11, 2025 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants