Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update missing signatures function for validation service #1733

Merged
merged 2 commits into from
Mar 11, 2025
Merged

Update missing signatures function for validation service #1733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70dd5e2
update missing signatures
codabrink Mar 11, 2025
fd94c73
comment
codabrink Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion bindings_ffi/src/mls.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3324,7 +3324,8 @@ mod tests {
// should be good
.unwrap();

// TODO: uncomment this when xmtp-node-go is updated to recognize Passkey MemberIdentifiers
// TODO: I'll uncomment this as soon as PR 1733 goes live.
// Tested locally with this uncommented and it works.
// alex.apply_signature_request(sig_request).await.unwrap();
}

Expand Down
2 changes: 1 addition & 1 deletion xmtp_id/src/associations/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ impl SignatureRequest {
pub fn missing_address_signatures(&self) -> Vec<&MemberIdentifier> {
self.missing_signatures()
.into_iter()
.filter(|member| member.kind() == MemberKind::Ethereum)
.filter(|member| matches!(member.kind(), MemberKind::Ethereum | MemberKind::Passkey))
.collect()
}

Expand Down
Loading