Skip to content
This repository was archived by the owner on Feb 28, 2025. It is now read-only.

Revoke Installation Companion PR #35

Merged
merged 45 commits into from
Jan 25, 2024
Merged

Revoke Installation Companion PR #35

merged 45 commits into from
Jan 25, 2024

Conversation

insipx
Copy link
Contributor

@insipx insipx commented Jan 19, 2024

Mostly QoL changes surrounding working with types related to did:ethr (ex: converting between enum representation to string representation of attribute name types)

adds sign_(attribute|delegate|owner) functions to the did_registry module. These are used for the setAttributeSigned/addDelegateSigned/changeOwnerSigned registry functions, necessary for the xps-gateway to submit transactions with DIDs that are owned by a different eth address.

Also formalizes a format for xmtp attributes as an extension to did:ethr, described in xmtp.rs. Adds this format to the current did_parser. These types will be shared with xps-gateway and libxmtp in order to use xps-gateway endpoints

companion to https://github.com/xmtp/xps-gateway/pull/38/files

misc changes:

  • runs coverage with trace logs, so we don't get missing codecov lines for log:: fns

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (8030963) 93.95% compared to head (bf348f5) 96.20%.

Files Patch % Lines
lib/src/error.rs 33.33% 2 Missing ⚠️
lib/src/resolver.rs 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   93.95%   96.20%   +2.25%     
==========================================
  Files          11       12       +1     
  Lines        1538     2055     +517     
==========================================
+ Hits         1445     1977     +532     
+ Misses         93       78      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@insipx insipx marked this pull request as ready for review January 25, 2024 17:16
Copy link
Contributor

@jac18281828 jac18281828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good to me. It would be nice to convert some of those IT to mocks once we are able!

@insipx insipx merged commit 4bf3d4b into main Jan 25, 2024
5 checks passed
@insipx insipx deleted the insipx/revoke-installation branch January 25, 2024 21:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants