This repository was archived by the owner on Feb 28, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
==========================================
+ Coverage 93.95% 96.20% +2.25%
==========================================
Files 11 12 +1
Lines 1538 2055 +517
==========================================
+ Hits 1445 1977 +532
+ Misses 93 78 -15 ☔ View full report in Codecov by Sentry. |
jac18281828
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good to me. It would be nice to convert some of those IT to mocks once we are able!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly QoL changes surrounding working with types related to did:ethr (ex: converting between enum representation to string representation of attribute name types)
adds
sign_(attribute|delegate|owner)
functions to thedid_registry
module. These are used for thesetAttributeSigned
/addDelegateSigned
/changeOwnerSigned
registry functions, necessary for the xps-gateway to submit transactions with DIDs that are owned by a different eth address.Also formalizes a format for xmtp attributes as an extension to did:ethr, described in
xmtp.rs
. Adds this format to the current did_parser. These types will be shared with xps-gateway and libxmtp in order to use xps-gateway endpointscompanion to https://github.com/xmtp/xps-gateway/pull/38/files
misc changes:
log::
fns