-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow to build wheels using cibuildwheel #294
Conversation
34c37c7
to
919613e
Compare
Now that #292 is merged, I pulled that new commit into this PR, so the wheel builds are working and tests are passing for linux targets. MacOS targets won't work until #293 goes in. You can see the wheels built by this PR in the workflow run. |
a88e18f
to
807ec96
Compare
@jonathangreen Yes, of course I'm interested :) |
The main blocker for windows wheels is that I don't know anything about Python builds on Windows, or really doing builds on windows in general 😆 cibuildwheel supports it, and GH actions has windows workers so I'm fairly sure its is quite doable to build the windows wheels are part of this workflow. |
@jonathangreen Do you know why "cp37-manylinux_aarch64" build is failing? |
807ec96
to
b864c31
Compare
It was passing when I originally made the PR. When I have a chance later today I'll take a look and see whats going on there. |
It looks like upstream Here is where I updated the workflow, so we exclude the same wheel builds that |
This PR adds a new workflow so that wheel builds are done like lxml using cibuildwheel, creating statically linked wheels for the platforms supported by cibuildwheel. See the
lxml
workflows/wheels.yml
here.This build a static wheel for each platform, runs the test suite using this wheel, and then uploads the wheel as a build artifact.
This should let us push wheels for all platforms out to PyPi. Right now the workflow just attaches the built wheels to the build as an artifact, since I don't have any access to PyPi for this repo. cibuildwheel has some guidance in their docs as to how to upload the built wheels to PyPi and could be added to the workflow as a follow up.
In order to successfully build static wheels for all the platforms these PR will need to be merged before this one: