Block lxml binaries to avoid libxml2 incompatibilities #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When xmlsec and lxml are linked to different libxml2 versions there can be subtle compatibility issues. Forcing lxml to install from source causes it to link to same system verision of libxml2 as xmlsec
Closed
|
@nosnilmot We're now doing version checking during XMLSec initialisation. Do you think this PR still applies? |
Those checks just report/abort on detected version mismatches, the aim of this PR was to prevent version mismatches.
As pointed out here ths PR does not achieve the desired goal, as it does not impact regular user installs, but it may still have some value for developers |
|
Closing as No Longer Applicable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When xmlsec and lxml are linked to different libxml2 versions there can be subtle compatibility issues. Forcing lxml to install from source causes it to link to same system verision of libxml2 as xmlsec.
See https://bugs.launchpad.net/lxml/+bug/1960668 for the sorts of issues this should solve.
This problem occurs because xmlsec is linked to system libxml2 library, but lxml binaries bundle and link to a private copy of libxml2 that may be a different and incompatible version.