Dev v4 #225
Merged
Dev v4 #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE!!! This change removes the alternate forms of a wrp message that were largely unused. This makes the usage more consistent and in line with the wrp.Observer/wrp.Processor/wrp.Modifier code.
BREAKING CHANGE:Simplify to just wrp.Message
BREAKING CHANGE!!! This change focuses on removing the sub-packages that probably should not have been included here, and moving moving the needed functionality into the main wrp package. Themes: - Validators became Processor implementors, making composition easier. - A number of Modifiers were added to replace other types of modifiers. An example of this is the ReplaceAnySelfLocator(). - Taking advantage of generics for less code when possible. - Testing for the different types of messages so mistakes are caught more automatically using expectations and reflection against the Message struct. This should help in detecting mistakes if fields are added.
BREAKING CHANGE:Remove sub-packages, refactor
Change the code to use msgp. Add benchmarks.
…p that way & cut out everything that doesn't seem completely needed.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #225 +/- ##
===========================================
+ Coverage 54.86% 90.67% +35.80%
===========================================
Files 34 11 -23
Lines 5193 1190 -4003
===========================================
- Hits 2849 1079 -1770
+ Misses 2138 91 -2047
+ Partials 206 20 -186
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
schmidtw
commented
Feb 6, 2025
denopink
approved these changes
Feb 6, 2025
johnabass
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, I finally got this to a place I think I can live with it ... the best way to view the code is to pull the
dev_v4branch and runpkgsiteto see the go docs to see what is going on. The code ended up being very similar to v3 though not compatible or worth trying to make backwards compatible in my opinion. I cut pretty deep. But I might not have cut deep enough.