Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change *Locator to be Locator. #166

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Change *Locator to be Locator. #166

merged 1 commit into from
Mar 12, 2024

Conversation

schmidtw
Copy link
Member

No description provided.

@schmidtw schmidtw requested a review from denopink March 12, 2024 23:31
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 51.40%. Comparing base (5e79fc5) to head (dedf960).

Files Patch % Lines
id.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #166   +/-   ##
=======================================
  Coverage   51.40%   51.40%           
=======================================
  Files          31       31           
  Lines        4739     4739           
=======================================
  Hits         2436     2436           
  Misses       2111     2111           
  Partials      192      192           
Flag Coverage Δ
unittests 51.40% <80.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@denopink denopink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@schmidtw schmidtw merged commit 727d830 into main Mar 12, 2024
17 checks passed
@schmidtw schmidtw deleted the locator branch March 12, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants