Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Role admin "Change Category" dialog should mask while saving #3757

Closed
amcclain opened this issue Aug 21, 2024 · 2 comments · Fixed by #3766 or #3921
Closed

Role admin "Change Category" dialog should mask while saving #3757

amcclain opened this issue Aug 21, 2024 · 2 comments · Fixed by #3766 or #3921

Comments

@amcclain
Copy link
Member

It does not, you see a mask on the panel underneath - not optimal, especially if a category change is not instantaneous. We want the UI feedback here to be quite reliable for something like admin role adjustments.

@amcclain
Copy link
Member Author

While we have this open, would be great to autoFocus the select

@Ryanseanlee Ryanseanlee linked a pull request Aug 24, 2024 that will close this issue
6 tasks
@amcclain
Copy link
Member Author

Re-opening this ticket - we mask during save but dialog then still stays open while parent refreshes, but now without a mask.

Dialog should save and close then parent should refresh - once save is done then dialog is done and should be dismissed. See pattern for primary editing, which follows this pattern. That will get the masking 100% right and also ensure that any error refreshing after a successful save isn't confusing - the save did actually happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants