Skip to content

Limit users from flipping the model upside-down #1839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025
Merged

Conversation

ijlal99
Copy link
Collaborator

@ijlal99 ijlal99 commented Mar 24, 2025

Fixes #1020
Fixes #1737

Copy link
Member

@paireks paireks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ijlal99

it doesn't work on my end, but maybe I miss something, I don't know the reason yet. To reproduce:

  1. Take any example file (I took this one: https://xeokit.github.io/xeokit-sdk/examples/buildings/#dotbim_BlenderHouse)
  2. Use navcube to show the model from Top (Click Top on the navcube)
  3. Rotate

Before the changes I could rotate it however I want (also upside down), right now model disappears after rotation, like this:
2025-03-25_19h41_10

@ijlal99
Copy link
Collaborator Author

ijlal99 commented Apr 3, 2025

Hi @paireks!

Thank you for catching the bug. I have update the PR with the fix. Can you please have a look at it again?

@ijlal99 ijlal99 requested review from xeolabs and paireks April 3, 2025 09:55
@MichalDybizbanskiCreoox
Copy link
Collaborator

Not strictly technical, but I'd suggest including issue/ticket references in commits for context and traceability.

@ijlal99
Copy link
Collaborator Author

ijlal99 commented Apr 3, 2025

Hi @MichalDybizbanskiCreoox!

Once the PR is approved, I'll change the commit messages to contain the ticket reference.

@MichalDybizbanskiCreoox
Copy link
Collaborator

Hi @MichalDybizbanskiCreoox!

Once the PR is approved, I'll change the commit messages to contain the ticket reference.

Ok, but keep in mind some PRs get merged skipping their approval.
Also not sure if changing a PR doesn't invalidate an approval.

Copy link
Member

@paireks paireks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked it on a few examples, and right now it seems to work on my end as expected.

@ijlal99
Copy link
Collaborator Author

ijlal99 commented Apr 14, 2025

Hi @xeolabs!

I believe this PR is ready to be merged now.

@xeolabs
Copy link
Member

xeolabs commented Apr 14, 2025

Hi @xeolabs!

I believe this PR is ready to be merged now.

Great! Could you just address @paireks comment above then we should be good to go.

@ijlal99
Copy link
Collaborator Author

ijlal99 commented Apr 15, 2025

I have already taken care of that in the latest push.

@xeolabs xeolabs merged commit eb7b662 into master Apr 15, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gimbal lock can be bypassed [FIX] Fix sudden camera inversion in CameraControl pivot mode
4 participants