-
Notifications
You must be signed in to change notification settings - Fork 306
Limit users from flipping the model upside-down #1839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @ijlal99
it doesn't work on my end, but maybe I miss something, I don't know the reason yet. To reproduce:
- Take any example file (I took this one: https://xeokit.github.io/xeokit-sdk/examples/buildings/#dotbim_BlenderHouse)
- Use navcube to show the model from Top (Click Top on the navcube)
- Rotate
Before the changes I could rotate it however I want (also upside down), right now model disappears after rotation, like this:
Hi @paireks! Thank you for catching the bug. I have update the PR with the fix. Can you please have a look at it again? |
Not strictly technical, but I'd suggest including issue/ticket references in commits for context and traceability. |
Once the PR is approved, I'll change the commit messages to contain the ticket reference. |
Ok, but keep in mind some PRs get merged skipping their approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked it on a few examples, and right now it seems to work on my end as expected.
src/viewer/scene/CameraControl/lib/controllers/PivotController.js
Outdated
Show resolved
Hide resolved
src/viewer/scene/CameraControl/lib/controllers/PivotController.js
Outdated
Show resolved
Hide resolved
Hi @xeolabs! I believe this PR is ready to be merged now. |
I have already taken care of that in the latest push. |
Fixes #1020
Fixes #1737