-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to modern Python project setup (setup.py
to pyproject.toml
)
#992
Conversation
build-backend = "setuptools.build_meta" | ||
|
||
[project] | ||
name = "xcube-core" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@konstntokas The name shouldn't have any effect on conda-forge: conda-forge's own package name (or names) is defined explicitly in meta.yaml
, and our feedstock configuration fetches the xcube source straight from GitHub so it doesn't care about the PyPI name.
6af11c3
to
be78bf0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor change request, otherwise fine :)
build-backend = "setuptools.build_meta" | ||
|
||
[project] | ||
name = "xcube-core" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@konstntokas The name shouldn't have any effect on conda-forge: conda-forge's own package name (or names) is defined explicitly in meta.yaml
, and our feedstock configuration fetches the xcube source straight from GitHub so it doesn't care about the PyPI name.
Co-authored-by: Pontus Lurcock <pontus.lurcock@brockmann-consult.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
This PR updates the setup of
xcube
usingpyproject.toml
instead ofsetup.py
. I tested new setup by installing it locally and by uploading it to TestPyPI and installing it withpip install -i https://test.pypi.org/simple/ xcube-core==1.6.0.dev2
Checklist:
Add unit tests and/or doctests in docstringsAdd docstrings and API docs for any new/modified user-facing classes and functionsNew/modified features documented indocs/source/*
CHANGES.md