-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data descriptions #1122
Data descriptions #1122
Conversation
…dataset_descriptions # Conflicts: # xcube/webapi/places/context.py
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1122 +/- ##
=======================================
Coverage 89.32% 89.32%
=======================================
Files 277 277
Lines 21293 21319 +26
=======================================
+ Hits 19020 19044 +24
- Misses 2273 2275 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor comment. Also, I did not see any changes in the viewer. I was just reviewing the server setup, though, and everything looks good.
def setUp(self): | ||
self.maxDiff = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you set it here, you can remove it at the starts of tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right.
You need to checkout the corresponding branch. Viewer changes are notyet bundled. |
This PR requires xcube-dev/xcube-viewer#466 for review.
xcube Server now can be configured to provide abstracts/descriptions for datasets so they can be rendered as markdown in xcube Viewer (xcube-dev/xcube-viewer#454).
description
properties have been added to responses from xcube Server for datasets and variables.Description
now accompanies settings such asTitle
.Description
setting are derived from metadata of datasets and variable CF attributes.Closes #1121
Checklist:
docs/source/*
CHANGES.md