Server-side panels #1085
Merged
Server-side panels #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-yogesh
approved these changes
Nov 12, 2024
| ServiceContact: | ||
| IndividualName: "Norman Fomferra" | ||
| PositionName: "Senior Software Engineer" | ||
| ContactInfo: |
There was a problem hiding this comment.
This info is outdated, pleas update with the following:
ContactInfo:
Phone:
Voice: +49 40 696 389 300
Facsimile: +49 40 696 389 399
Address:
DeliveryPoint: Chrysanderstr. 1
City: Hamburg
AdministrativeArea: Hamburg
PostalCode: 21029
Country: Germany
ElectronicMailAddress: info@brockmann-consult.de
There was a problem hiding this comment.
We should remove this entirely
pont-us
approved these changes
Nov 13, 2024
Comment on lines
+48
to
+49
| - pip: | ||
| - git+https://github.com/bcdev/chartlets.git#subdirectory=chartlets.py |
There was a problem hiding this comment.
I assume this is temporary until Chartlets gets a conda-forge release?
| path = Path(augmentation["Path"]) | ||
| if not path.is_absolute(): | ||
| path = Path(self.base_dir) / path | ||
| with prepend_sys_path(path): |
There was a problem hiding this comment.
I feel as though there ought to be a more elegant way to do this without changing the system path globally, but on closer examination it seems that alternative approaches would need quite a lot of import system surgery :(.
There was a problem hiding this comment.
If you know anything better, please report back to me!
AliceBalfanz
approved these changes
Nov 13, 2024
TejasMorbagal
approved these changes
Nov 13, 2024
Co-authored-by: Pontus Lurcock <pontus.lurcock@brockmann-consult.de>
Co-authored-by: Pontus Lurcock <pontus.lurcock@brockmann-consult.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows extending xcube Viewer by custom panels defined in xcube Server.
Added experimental feature that allows for extending the xcube Viewer user interface by server-side panels. For this to work, users can now configure xcube Server to load one or more Python modules that provide
xcube.webapi.viewer.contrib.PanelUI-contributions. Panel instances provide two decoratorslayout()andcallback()which are used to implement the UI and the interaction behaviour, respectively. The functionality is provided by the https://github.com/bcdev/chartlets Python library. A working example can be found inexamples/serve/panels-demo.Related xcube Viewer PR: xcube-dev/xcube-viewer#438
Checklist:
[ ] New/modified features documented indocs/source/*CHANGES.md