Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make time parameter optional in xcube server's /statistic endpoint #1070

Merged
merged 14 commits into from
Sep 17, 2024
Merged

Make time parameter optional in xcube server's /statistic endpoint #1070

merged 14 commits into from
Sep 17, 2024

Conversation

b-yogesh
Copy link
Contributor

@b-yogesh b-yogesh commented Sep 11, 2024 •
edited
Loading

This PR makes the time dimension optional for calculating the stats of datasets that do not contain any time dimension.

Closes #1066

Checklist:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/source/*
  • Changes documented in CHANGES.md
  • GitHub CI passes
  • AppVeyor CI passes
  • Test coverage remains or increases (target 100%)

@forman forman self-requested a review September 11, 2024 13:47
@forman forman mentioned this pull request Sep 11, 2024
Merged
7 tasks
@b-yogesh b-yogesh marked this pull request as ready for review September 12, 2024 09:17
@b-yogesh b-yogesh marked this pull request as draft September 12, 2024 09:17
@b-yogesh b-yogesh marked this pull request as ready for review September 12, 2024 12:09
@forman forman changed the title Initial commit for making time optional in xcube server Make time optional in xcube server's /statistic endpoint Sep 12, 2024
@forman forman changed the title Make time optional in xcube server's /statistic endpoint Make time parameter optional in xcube server's /statistic endpoint Sep 12, 2024
forman
forman requested changes Sep 12, 2024
View reviewed changes
b-yogesh and others added 4 commits September 12, 2024 16:25
@b-yogesh @forman
Update xcube/webapi/statistics/controllers.py
dd98ae7 
Co-authored-by: Norman Fomferra <norman.fomferra@brockmann-consult.de>
@b-yogesh @forman
Update CHANGES.md
e2998a3 
Co-authored-by: Norman Fomferra <norman.fomferra@brockmann-consult.de>
@b-yogesh @forman
Update xcube/webapi/statistics/controllers.py
ab309b5 
Co-authored-by: Norman Fomferra <norman.fomferra@brockmann-consult.de>
@b-yogesh @forman
Update xcube/webapi/statistics/controllers.py
984dddc 
Co-authored-by: Norman Fomferra <norman.fomferra@brockmann-consult.de>
@b-yogesh b-yogesh marked this pull request as draft September 12, 2024 14:49
@b-yogesh b-yogesh marked this pull request as draft September 12, 2024 14:49
@b-yogesh b-yogesh marked this pull request as ready for review September 12, 2024 15:34
@b-yogesh b-yogesh requested a review from forman September 12, 2024 15:34
forman
forman approved these changes Sep 12, 2024
View reviewed changes
forman
forman approved these changes Sep 12, 2024
View reviewed changes
@b-yogesh b-yogesh requested a review from forman September 13, 2024 07:17
forman
forman approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@forman forman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! Your first contribution to xcube!

@forman forman merged commit 5c6ddb2 into main Sep 17, 2024
3 checks passed
@b-yogesh b-yogesh deleted the b-yogesh-1066-stats-optional-time branch October 11, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forman forman forman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The "/statistics" endpoint's query parameter "time" should be optional
2 participants
@b-yogesh @forman