Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix of xcube server config colormaps schema #1063

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

konstntokas
Copy link
Contributor

@konstntokas konstntokas commented Aug 21, 2024

This PR resolves a bug in the xcube server configuration related to the colormaps schema. In PR #1057, the ColorBar field within the Styles section of the config was incorrectly set as a required field. To ensure backward compatibility, this PR removes the ColorBar field from the list of required fields.

Checklist:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/source/*
  • Changes documented in CHANGES.md
  • GitHub CI passes
  • AppVeyor CI passes
  • Test coverage remains or increases (target 100%)

@konstntokas konstntokas requested a review from pont-us August 21, 2024 09:56
@pont-us pont-us merged commit ef5a243 into main Aug 21, 2024
4 checks passed
@pont-us
Copy link
Member

pont-us commented Aug 21, 2024

Approved and merged!

@konstntokas konstntokas deleted the konstntokas-xxx-bugfix_server_config_colormaps_schema branch October 11, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants