Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove display_name from target.get_or_create call (issue 1698) #731

Merged
merged 1 commit into from
Mar 7, 2025
Merged

Remove display_name from target.get_or_create call (issue 1698) #731

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion viewer/target_loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1613,7 +1613,6 @@ def process_bundle(self):

self.target, target_created = Target.objects.get_or_create(
title=self.target_name,
display_name=self.target_name,
project=self.project,
)

Expand All @@ -1622,6 +1621,7 @@ def process_bundle(self):
# mypy thinks target and target_name are None
target_dir = sanitize_directory_name(target_dir, self.abs_final_path) # type: ignore [arg-type]
self.target.zip_archive = target_dir # type: ignore [attr-defined]
self.target.display_name = self.target_name # type: ignore [attr-defined]
self.target.save() # type: ignore [attr-defined]
else:
# NB! using existing field zip_archive to point to the
Expand Down