Merged fixes for issues 1262, 1432, 1514, 1524 and 1552 #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NB! while there are no changes to the way the data is stored in the db, the loader is incompatible with the old format. Trying to load an earlier tarball will fail.
attribute name in API is 'current_identifier'
Issues merged: - 1262 - 1432 - 1514 - 1524 - 1552
After migrations were on hold for a while, merging back several issues with migrations caused a migration error. This was caused by sligtly wrong order of procedures (possibly as a result of an automatic merge) but also an oversight on my part - as the compound identifiers are loaded from compounds_manual.csv during LHS data loading I didn't think to test with RHS data, but evidently this partly touches the same models and filled the tables with incompatible data types. This patch should resolve these issues without a data loss.
mwinokan
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.