[Builtins][MediaWindow] Propagate window replace intention and set th…

[enen92]

…e start directory

Description

#17893 introduced a regression when using the ReplaceWindow builtin. The main issue lies in the fact that the new logic don't set the start directory if we came from the same window as we are just adding a new path to the window history. The problem is that, with replace window, the last window is in fact being popped from the window history by the window manager. This means that if we replace the same window with a different path chances are the window won't move to the new path.

To fix it, I'm propagating this replace/swapping window intention as a string parameter thus reinstating the previous ReplaceWindow behaviour while keeping the same ActivateWindow behaviour.

@ronie @roidy can you guys check if you can still reproduce the issue?

The previous PR should have not been backported as I said here (#17893 (comment)). As a result we now have the ReplaceWindow and a few skins broken in Leia. I'll add a backport label just in case we decide to make yet another final-final-reallyfinal Leia version (@DaveTBlake fyi).

Motivation and Context

Fix #18239

How Has This Been Tested?

Using a simple python script:

    xbmc.executebuiltin("ActivateWindow(Videos,videodb://movies/titles/,return)")
    xbmc.sleep(3000)
    xbmc.executebuiltin("ReplaceWindow(Videos,videodb://movies/genres/,return)")
    xbmc.sleep(5000)
    xbmc.executebuiltin("ReplaceWindow(Videos,videodb://movies/titles/,return)")

[enen92]

jenkins build this please

[ronie]

tested and didn't spot any issues, lgtm.

[phunkyfish]

LGTM