This repository has been archived by the owner on May 9, 2022. It is now read-only.
TY-1759 move serialized bytes allocation from dart to rust #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Summary
CBytes
in rust and use it in the dart wrapper: we don't have to differentiate between owned/borrowed for theBytes
in dart, destructor always runs in rust; but this can potentially panic, which requires more complex try-catches in dart.also the
ExternError
is getting more and more annoying (cumbersome message freeing, unnecessary*const
/*mut
casts,i32
limitation for the code, noimpl From<Infallible> for ExternError
, etc). depending on how we want to unify the c error handling with the wasm error handling after #51, we should think about refactoring this as well.