Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File descriptor not closed when exception raised in Zip.open_in funct… #18

Merged
merged 1 commit into from
Mar 19, 2019
Merged

File descriptor not closed when exception raised in Zip.open_in funct… #18

merged 1 commit into from
Mar 19, 2019

Conversation

dweil
Copy link
Contributor

@dweil dweil commented Mar 15, 2019

…ion, close #17

xavierleroy
xavierleroy approved these changes Mar 19, 2019
View reviewed changes
Copy link
Owner

@xavierleroy xavierleroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the patch.

@xavierleroy xavierleroy merged commit 0e3fa45 into xavierleroy:master Mar 19, 2019
@dweil
Copy link
Contributor Author

dweil commented Mar 20, 2019

Thanks. Any idea when you plan to release a version on opam ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavierleroy xavierleroy xavierleroy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

file descriptor not closed when exception raised in Zip.open_in function
2 participants
@dweil @xavierleroy