Add udev rules for PureStorage - best practices #729
Conversation
This commit integrates PureStorage-recommended udev rules to optimize queue settings for Citrix XenServer. These changes follow the guidelines outlined in the PureStorage Knowledge Base article [#kbid](https://support.purestorage.com/bundle/m_citrix/page/Solutions/Citrix/Citrix_XenServer/topics/task/t_applying_queue_settings_with_udev.html). Key changes: - Implemented udev rules to adjust IO scheduler and queue depth for PureStorage volumes. - Ensured compliance with existing XenServer storage management (SM) conventions. - Verified functionality through test scenarios to avoid regression with non-PureStorage configurations. Motivation: These changes aim to improve performance and reliability for deployments using PureStorage arrays, adhering to vendor-recommended best practices while maintaining compatibility with the broader XenServer ecosystem. Testing: - Manually verified udev rules on test systems with PureStorage arrays. - Confirmed compatibility with non-PureStorage environments. - Ran unit tests for related storage subsystems. This change is backward-compatible, introduces no breaking changes and only affect PureStorage arrays. Signed-off-by: Yann LE BRIS <yann.lebris@vates.tech>
ylebris
force-pushed
the
upstream-iscsi-optimization-purestorage
branch
from
83bc183 to
bfbb200
Compare
ylebris
changed the title
|
@MarkSymsCtx ready to be reviewed |
|
I would much rather see this submitted to XenServer from Pure themselves through our Partner relationship team than to take an essentially random PR that we are unable to test. |
|
Hi It's not a random PR, Yann is working at Vates. Also, the PR points to the reference from Pure Storage. If you want someone from Pure to write a message in here, this is doable. Thanks for reviewing the PR. |
|
The kbid make no mention of modifying the udev rules for DM devices only for the sd devices that match the PURE vendor. |
Signed-off-by: Yann LE BRIS <yann.lebris@vates.tech>
ylebris
force-pushed
the
upstream-iscsi-optimization-purestorage
branch
from
21822da to
cefeb90
Compare
|
@MarkSymsCtx you can review again. |
| ACTION=="add|change", KERNEL=="dm-[0-9]*", SUBSYSTEM=="block", ENV{DM_NAME}=="3624a937*", ATTR{queue/rq_affinity}="2" | ||
|
|
||
| # Set the HBA timeout to 60 seconds | ||
| ACTION=="add", SUBSYSTEMS=="scsi", ATTRS{model}=="FlashArray ", RUN+="/bin/sh -c 'echo 60 > /sys/$DEVPATH/device/timeout'" |
There was a problem hiding this comment.
Pure engineering have reviewed this and requested that this line be changed to
ACTION=="add", SUBSYSTEMS=="scsi", ATTRS{model}=="FlashArray ", ATTR{device/timeout}="60"
There was a problem hiding this comment.
The change seems reasonable, but you asked us to change our PR to match the vendor KB, and now you ask us to diverge from the vendor KB, for a change which at first sight does the same thing, albeit in a cleaner way (but I'm no expert in udev rules so I might be wrong). Does Pure engineering intend to update their KB with their own request?
There was a problem hiding this comment.
We independently raised this directly with Pure engineering through their support team, it's taken them that long to come back to us with an answer to confirm that aside from that one line they are happy with the change.
There was a problem hiding this comment.
Thanks. Let's hope they have the reflex to update the KB later on :)
There was a problem hiding this comment.
We have asked them that as well.
This commit integrates PureStorage-recommended udev rules to optimize queue settings for Citrix XenServer. These changes follow the guidelines outlined in the PureStorage Knowledge Base article #kbid.
Key changes:
Motivation:
These changes aim to improve performance and reliability for deployments using PureStorage arrays, adhering to vendor-recommended best practices while maintaining compatibility with the broader XenServer ecosystem.
Testing:
This change is backward-compatible, introduces no breaking changes and only affect PureStorage arrays.