Skip to content
This repository was archived by the owner on May 1, 2024. It is now read-only.

Ignore empty cache and don't cache invalid stream #7764

Merged
merged 2 commits into from
Oct 7, 2019
Merged

Conversation

PureWeen
Copy link
Contributor

@PureWeen PureWeen commented Oct 1, 2019

Description of Change

  • If the stream returned from the HttpClient is invalid the code was still creating an empty cache file which would cause subsequent calls to just use an empty file for the image instead of retrying to stream
  • If the cached file is empty then don't use it and just retry the remote stream.

Issues Resolved

Platforms Affected

  • Core/XAML (all platforms)
  • iOS
  • Android
  • UWP

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@PureWeen PureWeen merged commit 5ef1deb into 4.1.0 Oct 7, 2019
@PureWeen PureWeen deleted the image_cache_fix branch October 7, 2019 15:41
@samhouts samhouts added this to the 4.3.0 milestone Oct 17, 2019
@samhouts samhouts modified the milestones: 4.3.0, 4.2.0 Oct 17, 2019
CliffAgius pushed a commit to CliffAgius/Xamarin.Forms that referenced this pull request Dec 6, 2019
* Ignore empty cache and don't cache invalid stream

* - msbuild locator
@serbesthamit
Copy link

Goto Android Project, then click on properties,
click on assemblyinfo.cs
[assembly: Application(UsesCleartextTraffic = true)]

https://forums.xamarin.com/discussion/164771/cleartext-http-traffic-not-permitted

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants