This repository was archived by the owner on May 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Enhancement] Add Visual progress behind feature flag #4449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephaneDelcroix
suggested changes
Nov 20, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for the part where you shuffle stuffs that were not misplaced, I think that the Core stuffs are nice.
ccc620d
to
e3e1ed0
Compare
samhouts
approved these changes
Nov 21, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No blockers!
StephaneDelcroix
approved these changes
Nov 22, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no blocker.
@@ -389,5 +390,26 @@ public override object ConvertFromInvariantString(string value) | |||
return new ButtonContentLayout(position, spacing); | |||
} | |||
} | |||
|
|||
|
|||
protected override void OnPropertyChanged([CallerMemberName] string propertyName = null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't usually override OnPropertyChanged but hook into the BP propertyChanged:
, but this is fine
rmarinho
approved these changes
Nov 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
a/visual
API-change
Heads-up to reviewers that this PR may contain an API change
p/Android
p/iOS 🍎
p/UWP
roadmap
t/enhancement ➕
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Add a Visual property to VisualElement that allows us to swap out different renderers based on a Visual Type property
fixes #4435
This PR also adds a starting set of Material Renderers as the first use case for this behavior
API Changes
Added:
Platforms Affected
Before/After Screenshots
There should be no visual changes to standard Default Renderers
Here is the view when using Material Visuals
Testing Procedure
PR Checklist