-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[GTK] Fix wrong indentation using spaces instead of tabs #3743
Conversation
Per the Coding Style:
|
Most of the files in the Xamarin.Forms.Platform.Gtk uses spaces instead of tabs, that's why I though the default was spaces instead of tabs :) I will fix this PR fixing it the other way around, changing spaces with tabs in the rest of the files. I know how to change the settings on the IDE, but the format policies can be also included in the solution file and it would avoid inconsistencies in the formatting like the ones in the Xamarin.Forms.Platform.Gtk project Example of a solution including them:
|
903310b
to
22d06a4
Compare
22d06a4
to
bbc1df9
Compare
Unfortunately this is a total history destruction kind of deal so we're not going to take this PR :( It would be nice but it means anything before this PR in any of these files is effectively lost when trying to do things like git blame. Maybe there is a way around this I dont know, if there is please feel free to re-open and drop some knowledge on me :) |
This makes contributing to Xamarin.Forms very difficult, specially when trying to follow the coding style defined by your team. Auto-indentation is a key feature in any IDE and lot of people use it with VS and vs4mac, and with the current status of Xamarin.Forms.Platform.Gtk it's impossible to use. If standards for coding style are not set and respected code will get worst long term. |
And there is a way in git to ingore spaces/tabs with the --ignore-all-space switch: |
Description of Change
Fix wrong indentation in some files in the GTK backend project that are using tabs instead of spaces
For those using auto-indentation in vs4mac having different indentations and policies makes it harder to contribute to the project.
It would be also nice to have the code formatting policies added at the solution level so it's easier for contributors to follow to same code formatting standard.