Skip to content
This repository was archived by the owner on May 1, 2024. It is now read-only.

[C] VisibilityConverter Trims input #3581

Merged
merged 1 commit into from
Aug 16, 2018
Merged

[C] VisibilityConverter Trims input #3581

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions Xamarin.Forms.Core/VisualElement.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -920,13 +920,14 @@ public class VisibilityConverter : TypeConverter
{
public override object ConvertFromInvariantString(string value)
{
if (value != null)
value = value?.Trim();
if (!string.IsNullOrEmpty(value))
{
if (value.Equals("true", StringComparison.OrdinalIgnoreCase))
if (value.Equals(Boolean.TrueString, StringComparison.OrdinalIgnoreCase))
return true;
if (value.Equals("visible", StringComparison.OrdinalIgnoreCase))
return true;
if (value.Equals("false", StringComparison.OrdinalIgnoreCase))
if (value.Equals(Boolean.FalseString, StringComparison.OrdinalIgnoreCase))
return false;
if (value.Equals("hidden", StringComparison.OrdinalIgnoreCase))
return false;
Expand Down