This repository was archived by the owner on May 1, 2024. It is now read-only.
[iOS] Add using statement to dispose stream #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -197,7 +199,7 @@ public sealed class ImageLoaderSourceHandler : IImageSourceHandler | |||
| var imageLoader = imagesource as UriImageSource; | |||
| if (imageLoader != null && imageLoader.Uri != null) | |||
| { | |||
| using(var streamImage = await imageLoader.GetStreamAsync(cancelationToken).ConfigureAwait(false)) | |||
| using (var streamImage = await imageLoader.GetStreamAsync(cancelationToken).ConfigureAwait(false)) | |||
There was a problem hiding this comment.
@hartez Ctrl-k-f using the Xamarin.Forms.vssettings added this space before the using statement.. Earlier in the file a case statements was also re-formatted. Do we want Ctrl-k-f to be a no-op for all files in the repro?
There was a problem hiding this comment.
Looks like the Resharper settings are "no space before the parenthesis after using", so I just go that wrong in the VS settings file. I'll put in a PR.
kingces95
changed the title
|
👍 |
jsuarezruiz
pushed a commit
to PlainConcepts/Xamarin.Forms
that referenced
this pull request
Sep 7, 2017
…ight Fixed HasUnevenRows and transparent separator color error in ListView
shyunMin
pushed a commit
to shyunMin/Xamarin.Forms
that referenced
this pull request
Dec 11, 2020
[M1] Enhances the XStopWatch app
mattleibow
pushed a commit
that referenced
this pull request
Jan 28, 2021
* browser launch url implementation (no file scheme) * Refactor code and upgrade nugets! Added documentation. * Add browser tests * Refactor code * refactor a bit more. * Add 1G to Android samples * Update java heap on device tests * Rename enums and cleanup based on feedback. * Fix typos in docs. * One set of docs got missed. * Add a check to see if intent is supported before calling it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Add using statement to dispose stream.
Bugs Fixed
https://bugzilla.xamarin.com/show_bug.cgi?id=39896
PR Checklist