Upgrade Rubocop target Ruby version and apply suggested fixes #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
peteryates
commented
Jan 28, 2024
peteryates
commented
- Set TargetRubyVersion to 3.1
- Run Rubocop with autocorrect
✅ Deploy Preview for govuk-form-builder ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Removing the HashSyntax disabling here so we can follow up with the removal of value variables that match key names
This is mainly: * tidying up hashes where the values are variables named after the key * removing unnecessary freezing
peteryates
force-pushed
the
upgrade-rubocop-target-version-and-apply-suggestions
branch
from
064baad to
b4df313
Compare
peteryates
deleted the
upgrade-rubocop-target-version-and-apply-suggestions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.