Add pickle support #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briangrahamww
requested review from
kzecchini,
weightwatchers-carlanderson and
mskarlinski-ww
reka-ww
reviewed
Nov 14, 2019
kzecchini
reviewed
Nov 21, 2019
|
@briangrahamww quick comment on keeping track of supported serializers - let me know if that makes sense. Otherwise I think it looks good and I'll approve! |
Now they are kept track of and it streamlined the code! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some objects that could only be serialized/deserialized properly using pickle and not dill, so I created a new reader and writer,
deserializer.pyandserializer.py, respectively.These new classes copy the dill reader and writer, but have an additional config variable to specify whether to use
dillorpickleserialization packages. I left the dill reader and writer for now, but we can deprecate and remove in a future release that has other breaking changes.