-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix authentication flow with custom authentication extension. #6416
Fix authentication flow with custom authentication extension. #6416
Conversation
PR builder started |
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #6416 +/- ##
============================================
+ Coverage 45.99% 47.15% +1.16%
+ Complexity 15457 15234 -223
============================================
Files 1744 1745 +1
Lines 110303 105383 -4920
Branches 20091 19274 -817
============================================
- Hits 50729 49695 -1034
+ Misses 52307 48653 -3654
+ Partials 7267 7035 -232
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/13098051382
983f139
to
f945489
Compare
f945489
to
6f8e028
Compare
PR builder started |
PR builder completed |
PR builder started |
|
PR builder completed |
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/13110804129
Issue:
Fix following issue:
[1].
carbon-identity-framework/components/authentication-framework/org.wso2.carbon.identity.application.authentication.framework/src/main/java/org/wso2/carbon/identity/application/authentication/framework/handler/request/impl/DefaultRequestCoordinator.java
Line 350 in 5938f4d
[2].
carbon-identity-framework/components/authentication-framework/org.wso2.carbon.identity.application.authentication.framework/src/main/java/org/wso2/carbon/identity/application/authentication/framework/handler/step/impl/DefaultStepHandler.java
Line 672 in 5938f4d